[webkit-reviews] review requested: [Bug 85591] [Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt : [Attachment 147088] Patch proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 12 08:04:15 PDT 2012


Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 85591: [Gtk] Many tests revealed as passing after moving from Skipped to
test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591

Attachment 147088: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=147088&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Attaching a patch that unskips the sputnik tests in that list only. I left
other tests out of this patch because they were reported I can't be sure about
them passing in the 32bit bot since it has been a while since that bot doesn't
compile (it's fixed now, but still compiling atm) and so I can't be sure
whether they are passing now or not.

Sputnik tests, in the other hand, are consistently passing in GTK 64 bit bots
now and also passed in the last build in the 32bit bot that we have results for
(http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/24071/s
teps/layout-test/logs/stdio), so I'd say it's pretty safe to unskip them.


More information about the webkit-reviews mailing list