[webkit-reviews] review granted: [Bug 88863] [Qt][Win] Buildfix related to fromWinHBITMAP : [Attachment 147067] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has granted Csaba Osztrogonac
<ossy at webkit.org>'s request for review:
Bug 88863: [Qt][Win] Buildfix related to fromWinHBITMAP
https://bugs.webkit.org/show_bug.cgi?id=88863

Attachment 147067: Patch
https://bugs.webkit.org/attachment.cgi?id=147067&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=147067&action=review


Just a nitpick.

> Source/WebCore/platform/graphics/qt/ImageQt.cpp:59
>  Q_GLOBAL_STATIC(WebGraphicHash, _graphics)
>  
> +#if OS(WINDOWS) && HAVE(QT5)
> +Q_GUI_EXPORT QPixmap qt_pixmapFromWinHBITMAP(HBITMAP, int hbitmapFormat =
0);
> +#endif

Ideally this would be moved up a bit after the includes and before the global
static, as it's kind of part of the includes.