[webkit-reviews] review granted: [Bug 88860] Refactor InputType::receiveDroppedFiles to take DragData : [Attachment 147058] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 12 05:04:35 PDT 2012


Kent Tamura <tkent at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 88860: Refactor InputType::receiveDroppedFiles to take DragData
https://bugs.webkit.org/show_bug.cgi?id=88860

Attachment 147058: Patch
https://bugs.webkit.org/attachment.cgi?id=147058&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147058&action=review


> Source/WebCore/html/FileInputType.h:67
> -    virtual void receiveDroppedFiles(const Vector<String>&) OVERRIDE;
> +    virtual bool receiveDroppedFiles(const DragData*) OVERRIDE;

had better add a comment explaining what is the return value.


More information about the webkit-reviews mailing list