[webkit-reviews] review denied: [Bug 87965] Need customized toDOMStringList for IndexedDB JSC binding. : [Attachment 147016] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 87965: Need customized toDOMStringList for IndexedDB JSC binding.
https://bugs.webkit.org/show_bug.cgi?id=87965

Attachment 147016: Patch
https://bugs.webkit.org/attachment.cgi?id=147016&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147016&action=review


> Source/WebCore/ChangeLog:9
> +	   The generted toDOMStringList() can't convert an JSArray of Strings
to

typo: generted => generated

> Source/WebCore/bindings/js/JSDOMBinding.cpp:290
> +    if (!value.inherits(&JSArray::s_info))
> +	   return 0;

I think that isJSArray(value) would be the correct check here.

Also I think you need to add the code that corresponds to
v8ValueToWebCoreDOMStringList():

  if (V8DOMStringList::HasInstance(v8Value)) {
    ...;
  }

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2831
> +    "DOMString[]" => "RefPtr<DOMStringList>",
> +    "DOMStringList" => "RefPtr<DOMStringList>",

By the way, what's the difference between DOMString[] and DOMStringList after
this patch?