[webkit-reviews] review granted: [Bug 83156] [WIN] Simplify implementation of currentTime() : [Attachment 144916] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 11 17:47:01 PDT 2012
Brent Fulgham <bfulgham at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 83156: [WIN] Simplify implementation of currentTime()
https://bugs.webkit.org/show_bug.cgi?id=83156
Attachment 144916: Patch
https://bugs.webkit.org/attachment.cgi?id=144916&action=review
------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144916&action=review
I think this change looks great. Please consider retaining the comments I
mention in the detailed notes when you commit the change.
> Source/WTF/wtf/CurrentTime.cpp:-222
> -
I don't like losing the following comments, which I found very illuminating
about this routine.
Could you please copy these into your revised implementation so that
non-Windows people are aware that Windows ticks are in 100s of nanoseconds,
etc.?
More information about the webkit-reviews
mailing list