[webkit-reviews] review granted: [Bug 88804] [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag. : [Attachment 146902] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Alexis Menard (darktears)
<alexis.menard at openbossa.org>'s request for review:
Bug 88804: [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a
feature flag.
https://bugs.webkit.org/show_bug.cgi?id=88804

Attachment 146902: Patch
https://bugs.webkit.org/attachment.cgi?id=146902&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146902&action=review


> Source/WebCore/rendering/style/RenderStyle.h:1592
> +#if ENABLE(CSS_BOX_DECORATION_BREAK)
>      static EBoxDecorationBreak initialBoxDecorationBreak() { return DSLICE;
}
> +#endif

Nit: It's OK to not guard this in an ENABLE (will get compiled out if not
used).

> Source/WebCore/rendering/style/RenderStyleConstants.h:106
> +#if ENABLE(CSS_BOX_DECORATION_BREAK)

Nit: It's OK to not guard this in an ENABLE (doesn't take up space).

> Source/WebCore/rendering/style/StyleBoxData.h:84
>      bool m_hasAutoZIndex : 1;
>      unsigned m_boxSizing : 1; // EBoxSizing

Not related to your change, but we should change m_hasAutoZIndex to unsigned to
fix the packing on Windows.