[webkit-reviews] review granted: [Bug 88809] [BlackBerry] [BlackBerry] browser video player fullscreen mode (portrait) does not play well with rotation : [Attachment 146914] patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Antonio Gomes <tonikitoo at webkit.org>'s
request for review:
Bug 88809: [BlackBerry] [BlackBerry] browser video player fullscreen mode
(portrait) does not play well with rotation
https://bugs.webkit.org/show_bug.cgi?id=88809

Attachment 146914: patch
https://bugs.webkit.org/attachment.cgi?id=146914&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=146914&action=review


Looks good, but please fix before landing.

> Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp:740
>	   fullScreenRenderer->style()->setWidth(Length(width, Fixed));

As discussed, better check fullScreenRenderer->style as well.