[webkit-reviews] review requested: [Bug 88363] [chromium] Separate CCVideoDrawQuad and from the layer tree and video provider by removing ManagedTexture and WebVideoFrame pointers from the quad : [Attachment 146897] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 11 13:48:14 PDT 2012


Dana Jansens <danakj at chromium.org> has asked  for review:
Bug 88363: [chromium] Separate CCVideoDrawQuad and from the layer tree and
video provider by removing ManagedTexture and WebVideoFrame pointers from the
quad
https://bugs.webkit.org/show_bug.cgi?id=88363

Attachment 146897: Patch
https://bugs.webkit.org/attachment.cgi?id=146897&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
Right-o here's a new version without any pointer copies into the
CCVideoDrawQuad. We have our own array of FrameData in there now, and we're
using the pleasant WebTransformationMatrix as well.

Also got rid of the setMatrix() method on the quad - everything comes in thru
the constructor!

Also also moved the static constants used during draw out of the
CCVideoLayerImpl class into LRC where they are used.


More information about the webkit-reviews mailing list