[webkit-reviews] review granted: [Bug 88788] IndexedDB: Object stores are not successfully deleted : [Attachment 146882] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 88788: IndexedDB: Object stores are not successfully deleted
https://bugs.webkit.org/show_bug.cgi?id=88788

Attachment 146882: Patch
https://bugs.webkit.org/attachment.cgi?id=146882&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146882&action=review


> Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp:1117
> +    return (result < 0) ? -1 : (result > 0) ? 1 : result;

Nit: I find nested ternary operators hard to read.  I would probably do:
if (result < 0)
    return -1;
return (result > 0) ? 1 : 0;