[webkit-reviews] review requested: [Bug 88760] [soup] Prevent setting or editing httpOnly cookies from JavaScript : [Attachment 146878] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 11 11:18:02 PDT 2012


Christophe Dumez <christophe.dumez at intel.com> has asked  for review:
Bug 88760: [soup] Prevent setting or editing httpOnly cookies from JavaScript
https://bugs.webkit.org/show_bug.cgi?id=88760

Attachment 146878: Patch
https://bugs.webkit.org/attachment.cgi?id=146878&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
Based on the feedback, I'm now proposing this patch. The patch now fixes
setCookies() so that it processes all the cookies and not just the first one.
I have clearly documented with FIXME comments the methods that should be
removed later and provided by libsoup instead (optimally).

However, I hope we can land this patch like this and improve the code later
since this fixes a valid issue and getting a new and improved libsoup release
may take time.
I don't mind writing the patches for libsoup though if it helps.


More information about the webkit-reviews mailing list