[webkit-reviews] review granted: [Bug 35981] Can't apply a bottom-margin to the legend element : [Attachment 146736] Proposed fix, take the margin after into account.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 11 11:05:33 PDT 2012


Abhishek Arya <inferno at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 35981: Can't apply a bottom-margin to the legend element
https://bugs.webkit.org/show_bug.cgi?id=35981

Attachment 146736: Proposed fix, take the margin after into account.
https://bugs.webkit.org/attachment.cgi?id=146736&action=review

------- Additional Comments from Abhishek Arya <inferno at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146736&action=review


r=me

> Source/WebCore/ChangeLog:3
> +	   Can't apply a bottom-margin to the legend element

nit: probably like "Add bottom-margin support to legend element".

> Source/WebCore/rendering/RenderFieldset.cpp:108
> +	   LayoutUnit collapsedLegendExtend;

nit: probably s/Extend/Extent


More information about the webkit-reviews mailing list