[webkit-reviews] review granted: [Bug 88784] Speech JavaScript API: Make SpeechRecognitionError an Event : [Attachment 146858] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Hans Wennborg <hans at chromium.org>'s
request for review:
Bug 88784: Speech JavaScript API: Make SpeechRecognitionError an Event
https://bugs.webkit.org/show_bug.cgi?id=88784

Attachment 146858: Patch
https://bugs.webkit.org/attachment.cgi?id=146858&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146858&action=review


> Source/WebCore/Modules/speech/SpeechRecognitionError.h:52
> +    static PassRefPtr<SpeechRecognitionError> create() { return
create(OTHER, ""); }

Consider using emptyString() rather than "" if this is used only on the main
thread.  (It's ever so slightly faster.)

> LayoutTests/ChangeLog:10
> +	   * fast/speech/scripted/speechrecognition-errors.html: Added.

It looks like you forgot to "svn add" the -expected.txt file.  This patch will
cause the bots to turn red because this test is missing results.