[webkit-reviews] review granted: [Bug 88724] Update the time display of Chromium media controls : [Attachment 146842] Review this, including the fixes for skia.

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Silvia Pfeiffer
<silviapf at chromium.org>'s request for review:
Bug 88724: Update the time display of Chromium media controls
https://bugs.webkit.org/show_bug.cgi?id=88724

Attachment 146842: Review this, including the fixes for skia.
https://bugs.webkit.org/attachment.cgi?id=146842&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=146842&action=review


r=me with the suggested changes.

> Source/WebCore/rendering/RenderMediaControlsChromium.cpp:357
> +    int seconds = (int)fabsf(time);

WebKit C++ code should use C++-style casts rather than C-style cast

> Source/WebCore/rendering/RenderMediaControlsChromium.cpp:363
> +    int durationSecs = (int)fabsf(duration);

Ditto.