[webkit-reviews] review denied: [Bug 62218] Shadow Pseudo ID should be able to nest to point nested shadow DOM : [Attachment 146812] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 11 09:03:03 PDT 2012


Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Hajime Morrita
<morrita at google.com>'s request for review:
Bug 62218: Shadow Pseudo ID should be able to nest to point nested shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=62218

Attachment 146812: Patch
https://bugs.webkit.org/attachment.cgi?id=146812&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146812&action=review


I think you're missing expected file, and the bots are angry.

> Source/WebCore/ChangeLog:10
> +	   - updateSpecifiersWithElementName() didn't take nesting into
account.
> +	     tag history can contain selector entries which isn't marked as
ShadowDescendant yet.
> +	     such entry can be found by investigating isUnknownPseudoElement().


I am curious when this happens.


More information about the webkit-reviews mailing list