[webkit-reviews] review granted: [Bug 88743] Change mute button and volume slider behaviour for new Chrome video controls : [Attachment 146766] Use this for review

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Silvia Pfeiffer
<silviapf at chromium.org>'s request for review:
Bug 88743: Change mute button and volume slider behaviour for new Chrome video
controls
https://bugs.webkit.org/show_bug.cgi?id=88743

Attachment 146766: Use this for review
https://bugs.webkit.org/attachment.cgi?id=146766&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=146766&action=review


> Source/WebCore/html/shadow/MediaControlElements.cpp:904
> +    , m_unmute(false)

"unmute" is a confusing name. The flag means "set muted to false on user
interaction", so maybe something like "m_clearMutedOnUserInteraction"?

> Source/WebCore/html/shadow/MediaControlElements.cpp:948
> +void MediaControlVolumeSliderElement::setUnmuteOnInteraction(bool unmute)

Ditto for "setUnmute"