[webkit-reviews] review granted: [Bug 88710] Web Inspector: Open links in Sources panel by default and fallback to Resources and Network panel otherwise. : [Attachment 146704] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 88710: Web Inspector: Open links in Sources panel by default and fallback
to Resources and Network panel otherwise.
https://bugs.webkit.org/show_bug.cgi?id=88710

Attachment 146704: Patch
https://bugs.webkit.org/attachment.cgi?id=146704&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146704&action=review


> Source/WebCore/inspector/front-end/inspector.js:974
> +	   preferredPanels.push(this.panels["scripts"]);

this.panels.scripts

> Source/WebCore/inspector/front-end/inspector.js:975
> +    if (this.panels["resources"])

Nit: we should remove the hiddenPanels altogether and get rid of these checks.

> Source/WebCore/inspector/front-end/inspector.js:976
> +	   preferredPanels.push(this.panels["resources"]);

ditto

> Source/WebCore/inspector/front-end/inspector.js:978
> +	   preferredPanels.push(this.panels["network"]);

ditto