[webkit-reviews] review denied: [Bug 88634] [EFL] Add AC related files and flags to EFL build system. : [Attachment 146513] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Hyowon Kim
<hw1008.kim at samsung.com>'s request for review:
Bug 88634: [EFL] Add AC related files and flags to EFL build system.
https://bugs.webkit.org/show_bug.cgi?id=88634

Attachment 146513: Patch
https://bugs.webkit.org/attachment.cgi?id=146513&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=146513&action=review


> ChangeLog:6
> +	   Reviewed by NOBODY (OOPS!).

Missing description.

> Source/WTF/ChangeLog:6
> +	   Reviewed by NOBODY (OOPS!).

ditto.

> Source/WebCore/ChangeLog:10
> +	   * PlatformEfl.cmake:

ditto.

> Source/cmake/OptionsEfl.cmake:40
> +FIND_PACKAGE(OpenGL REQUIRED)

Move this to line 26 as below,

FIND_PACKAGE(Cairo 1.10 REQUIRED)
FIND_PACKAGE(EFL REQUIRED)
FIND_PACKAGE(Fontconfig 2.8.0 REQUIRED)
+FIND_PACKAGE(OpenGL REQUIRED)
FIND_PACKAGE(Sqlite REQUIRED)