[webkit-reviews] review granted: [Bug 88612] Required state tracking of RadioButtonGroup should be loose : [Attachment 146475] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 88612: Required state tracking of RadioButtonGroup should be loose
https://bugs.webkit.org/show_bug.cgi?id=88612

Attachment 146475: Patch
https://bugs.webkit.org/attachment.cgi?id=146475&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146475&action=review


Okay. We can always roll it out if the perf. regression becomes an issue.

> Source/WebCore/dom/CheckedRadioButtons.cpp:82
> +    m_isRequired = false;
> +    typedef HashSet<HTMLInputElement*>::const_iterator Iterator;
> +    Iterator end = m_members.end();

We can make use of some blank lines here.

> Source/WebCore/dom/CheckedRadioButtons.cpp:86
> +	   HTMLInputElement* button = *it;
> +	   ASSERT(button->isRadioButton());
> +	   if (button->required()) {

Is there a point in copying *it to button? Can't we just directly use it?