[webkit-reviews] review granted: [Bug 87658] [Gtk] Add support in DumpRenderTree for tracking repaints : [Attachment 146225] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 8 15:53:26 PDT 2012


Martin Robinson <mrobinson at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 87658: [Gtk] Add support in DumpRenderTree for tracking repaints
https://bugs.webkit.org/show_bug.cgi?id=87658

Attachment 146225: Patch
https://bugs.webkit.org/attachment.cgi?id=146225&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146225&action=review


When landing please update all pixel results in the repaint directory.

> Tools/DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:44
> +    cairo_set_source_rgba(context, 0.0, 0.0, 0.0, 0.66);

Just use 0 here instead of 0.0, as that's the WebKit style.


More information about the webkit-reviews mailing list