[webkit-reviews] review granted: [Bug 88435] [chromium] Skip willDraw() and didDraw() on fully occluded layers : [Attachment 146310] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 8 13:43:24 PDT 2012


Adrienne Walker <enne at google.com> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 88435: [chromium] Skip willDraw() and didDraw() on fully occluded layers
https://bugs.webkit.org/show_bug.cgi?id=88435

Attachment 146310: Patch
https://bugs.webkit.org/attachment.cgi?id=146310&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=146310&action=review


R=me.  I'm curious how video frame uploads will work in an ubercomp world, but
this looks good for now.

> Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp:531
> +    // Make the viewport large so that we can have large layers that get
considered for occlusion (small layers do not).

Sad to have to bake these heuristic assumptions into tests.


More information about the webkit-reviews mailing list