[webkit-reviews] review granted: [Bug 86605] Rect-based hittesting doesn't work in tables. : [Attachment 145964] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Allan Sandfeld Jensen
<allan.jensen at nokia.com>'s request for review:
Bug 86605: Rect-based hittesting doesn't work in tables.
https://bugs.webkit.org/show_bug.cgi?id=86605

Attachment 145964: Patch
https://bugs.webkit.org/attachment.cgi?id=145964&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145964&action=review


r=me

> Source/WebCore/rendering/RenderTableSection.cpp:1112
> +    // FIXME: We should reevaluate if upper_bound is the correct choice
here.

A more precise comment would help. The issue is that upper_bound will ignore
empty rows. It may be fine for painting, not so much for hit testing.

Also currently rows / columns are handled slightly differently (upper_bound vs
lower_bound). I don't see why it should be different but it already was so
that's actually another FIXME :)

> Source/WebCore/rendering/RenderTableSection.h:226
> +    // The returned span of rows or columns is end-exclusive, and empty if
start==end.

Terrific, thanks for documenting that.