[webkit-reviews] review granted: [Bug 85793] Caret is not rendered in empty inline contenteditable elements : [Attachment 146383] Patch (without firstChild assertion)

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Shezan Baig
<shezbaig.wk at gmail.com>'s request for review:
Bug 85793: Caret is not rendered in empty inline contenteditable elements
https://bugs.webkit.org/show_bug.cgi?id=85793

Attachment 146383: Patch (without firstChild assertion)
https://bugs.webkit.org/attachment.cgi?id=146383&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146383&action=review


> Source/WebCore/rendering/RenderInline.cpp:244
> +    if (firstChild())
> +	   // This condition is possible if the RenderInline is at an editing
boundary,
> +	   // i.e. the VisiblePosition is:
> +	   //	<RenderInline editingBoundary=true>|<RenderText>
</RenderText></RenderInline>
> +	   // FIXME: need to figure out how to make this return a valid rect,
note that
> +	   // there are no line boxes created in the above case.
> +	   return LayoutRect();

You need curly brackets around this.