[webkit-reviews] review granted: [Bug 84054] webkitURL.createObjectURL uris generated from an SSL site are marked insecure : [Attachment 146501] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 8 11:13:09 PDT 2012


Adam Barth <abarth at webkit.org> has granted Mike West <mkwst at chromium.org>'s
request for review:
Bug 84054: webkitURL.createObjectURL uris generated from an SSL site are marked
insecure
https://bugs.webkit.org/show_bug.cgi?id=84054

Attachment 146501: Patch
https://bugs.webkit.org/attachment.cgi?id=146501&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146501&action=review


This looks great.  Thanks for iterating on the patch.

> Source/WebCore/page/SecurityOrigin.cpp:212
> +// static

nit: We usually skip these comments in WebKit.	There might be some in this
file already because I used to add them before I knew the right style.


More information about the webkit-reviews mailing list