[webkit-reviews] review denied: [Bug 88344] Fix FastMalloc.cpp compile error for MSVC in 64-bit : [Attachment 145851] patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied  review:
Bug 88344: Fix FastMalloc.cpp compile error for MSVC in 64-bit
https://bugs.webkit.org/show_bug.cgi?id=88344

Attachment 145851: patch
https://bugs.webkit.org/attachment.cgi?id=145851&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145851&action=review


>> Source/WTF/wtf/FastMalloc.cpp:2477
>>   private:
>> -  char pad_[(64 - (sizeof(TCMalloc_Central_FreeList) % 64)) % 64];
>> +	char pad[64 - (sizeof(TCMalloc_Central_FreeList) % 64)];
> 
> Clearly, whoever wrote this code didn't test it :(

On my second thought you should wrap this with
#if sizeof(TCMalloc_Central_FreeList) % 64
#endif
so that we don't increase the size when sizeof(TCMalloc_Central_FreeList) is a
multiple of 64.