[webkit-reviews] review granted: [Bug 88644] Using BlobBuilder should show a deprecation warning message (if it is enabled) : [Attachment 146561] Patch

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has granted Kinuko Yasuda <kinuko at chromium.org>'s
request for review:
Bug 88644: Using BlobBuilder should show a deprecation warning message (if it
is enabled)
https://bugs.webkit.org/show_bug.cgi?id=88644

Attachment 146561: Patch
https://bugs.webkit.org/attachment.cgi?id=146561&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146561&action=review


> Source/WebCore/ChangeLog:9
> +	   We should start showing a warning to let people migrate to use Blob
constructor.

nit: migrate to using

> Source/WebCore/fileapi/WebKitBlobBuilder.h:48
> +    // Special constructor for binding which shows deprecate warning before
calling the real constructor.

Probably better to add comment for both static creators to illustrate that
they're called in different scenarios.
For this one, consider something like:
  // Called when BlobBuilder is instantiated in JS API. We show deprecate
warning message.
For next one, consider something like:
  // Called by Blob constructor ...