[webkit-reviews] review canceled: [Bug 76834] Relative pos. input fields in columns vanish when you start typing in them : [Attachment 146533] Proposed Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has canceled Pravin D
<pravind.2k4 at gmail.com>'s request for review:
Bug 76834: Relative pos. input fields in columns vanish when you start typing
in them
https://bugs.webkit.org/show_bug.cgi?id=76834

Attachment 146533: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=146533&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146533&action=review


> Source/WebCore/page/FrameView.cpp:1121
> +				   (m_doFullRepaint ? 0 :
RenderLayer::CheckForRepaint | RenderLayer::UpdatePagination)

It's not totally right: m_doFullRepaint doesn't properly cover your case here.
You should only set UpdatePagination if you are doing a subtree relayout
(subtree) and the layer has the m_isPaginated flag set.

Please move the flag setting outside the function call (maybe in a new
function) as it will start to get messy.