[webkit-reviews] review granted: [Bug 87805] [Shadow DOM] <style> inside Shadow subtree should be scoped inside the subtree. : [Attachment 146465] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 87805: [Shadow DOM] <style> inside Shadow subtree should be scoped inside
the subtree.
https://bugs.webkit.org/show_bug.cgi?id=87805

Attachment 146465: Patch
https://bugs.webkit.org/attachment.cgi?id=146465&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146465&action=review


This turned out to be a sweet patch. Thanks for your hard work, tasak@! A few
nits that you are welcome to ignore (except spelling errors :).

> Source/WebCore/ChangeLog:41
> +	   method is invoked. Therefor we cannot rely on scoped()"

Therefor -> therefore

> Source/WebCore/ChangeLog:58
> +	   Added one new method scopedAttributeChanged's decalartion and

decalartion -> declaration

> Source/WebCore/html/HTMLStyleElement.h:89
> +    enum ScopedStyleRegisterType {

ScopedStyleRegistrationState

> Source/WebCore/html/HTMLStyleElement.h:94
> +    ScopedStyleRegisterType m_registeredWithScopingNode;

m_scopedStyleRegistrationState