[webkit-reviews] review granted: [Bug 88344] Fix FastMalloc.cpp compile error for MSVC in 64-bit : [Attachment 145851] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 8 01:40:46 PDT 2012
Ryosuke Niwa <rniwa at webkit.org> has granted Alex Christensen
<alex.christensen at flexsim.com>'s request for review:
Bug 88344: Fix FastMalloc.cpp compile error for MSVC in 64-bit
https://bugs.webkit.org/show_bug.cgi?id=88344
Attachment 145851: patch
https://bugs.webkit.org/attachment.cgi?id=145851&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145851&action=review
> Source/WTF/wtf/FastMalloc.cpp:2477
> - char pad_[(64 - (sizeof(TCMalloc_Central_FreeList) % 64)) % 64];
> + char pad[64 - (sizeof(TCMalloc_Central_FreeList) % 64)];
Clearly, whoever wrote this code didn't test it :(
More information about the webkit-reviews
mailing list