[webkit-reviews] review granted: [Bug 88450] Can't use eval in iframes sanbdoxed via CSP header : [Attachment 146145] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 8 00:24:39 PDT 2012


Mihai Parparita <mihaip at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 88450: Can't use eval in iframes sanbdoxed via CSP header
https://bugs.webkit.org/show_bug.cgi?id=88450

Attachment 146145: Patch
https://bugs.webkit.org/attachment.cgi?id=146145&action=review

------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146145&action=review


> Source/WebCore/bindings/v8/ScriptController.cpp:296
>      if (!m_proxy->windowShell()->initContextIfNeeded())

Nit: switch this to accessing m_proxy via proxy() for consistency with the
other uses you're adding.


More information about the webkit-reviews mailing list