[webkit-reviews] review denied: [Bug 88383] [Forms] Introduce Decimal behind the InputNumber type : [Attachment 146242] Patch 4

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 88383: [Forms] Introduce Decimal behind the InputNumber type
https://bugs.webkit.org/show_bug.cgi?id=88383

Attachment 146242: Patch 4
https://bugs.webkit.org/attachment.cgi?id=146242&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146242&action=review


Almost ok

> Source/WebCore/html/NumberInputType.cpp:215
> +    return value.isFinite() ? serializeForNumberType(value) : emptyString();


emptyString() should be String().  Do not change the function behavior though
it might have no side-effect.

> Source/WebCore/html/RangeInputType.cpp:223
> +    return value.isFinite() ? serializeForNumberType(value) : emptyString();


ditto.

> Source/WebCore/html/StepRange.h:49
> +    struct DecimalOrMissing {

Can you remove DecimalOrMissing by representing the missing state with
Decimal::nan()?

> Source/WebCore/html/parser/HTMLParserIdioms.cpp:65
> +	   // Decimal::toString append exponent, e.g. "0e-18"

append -> appends