[webkit-reviews] review granted: [Bug 88563] [BlackBerry] Show correct fullscreen button image (media controls) : [Attachment 146343] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 7 19:57:31 PDT 2012


Antonio Gomes <tonikitoo at webkit.org> has granted Max Feil <mfeil at rim.com>'s
request for review:
Bug 88563: [BlackBerry] Show correct fullscreen button image (media controls)
https://bugs.webkit.org/show_bug.cgi?id=88563

Attachment 146343: Patch
https://bugs.webkit.org/attachment.cgi?id=146343&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146343&action=review


> Source/WebCore/ChangeLog:15
> +	   I am not providing a test due to the simplicity of this patch
> +	   and the relative difficulty and maintainability issues associated
> +	   with testing how an image is rendered.
> +

I am not in love with this justification, but it is ok to go without a test for
this case :)


More information about the webkit-reviews mailing list