[webkit-reviews] review denied: [Bug 88517] [WebKit2] Only include Cocoa.h on platforms that use AppKit : [Attachment 146444] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 7 18:44:07 PDT 2012


Andy Estes <aestes at apple.com> has denied Andy Estes <aestes at apple.com>'s
request for review:
Bug 88517: [WebKit2] Only include Cocoa.h on platforms that use AppKit
https://bugs.webkit.org/show_bug.cgi?id=88517

Attachment 146444: Patch
https://bugs.webkit.org/attachment.cgi?id=146444&action=review

------- Additional Comments from Andy Estes <aestes at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=146444&action=review


> Source/WebKit2/config.h:84
>  #ifdef __OBJC__
> +#import <Foundation/Foundation.h>
> +#if USE(APPKIT)
>  #import <Cocoa/Cocoa.h>
>  #endif
> +#endif

Actually, there's no reason for this entire block since it's already in the
prefix header.


More information about the webkit-reviews mailing list