[webkit-reviews] review granted: [Bug 88028] [chromium] Provide access to the WebPlugin created by the helper plugin widget : [Attachment 146442] Call frameDetached() from WebHelperPluginImpl::close()

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted David Dorwin
<ddorwin at chromium.org>'s request for review:
Bug 88028: [chromium] Provide access to the WebPlugin created by the helper
plugin widget
https://bugs.webkit.org/show_bug.cgi?id=88028

Attachment 146442: Call frameDetached() from WebHelperPluginImpl::close()
https://bugs.webkit.org/attachment.cgi?id=146442&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146442&action=review


> Source/WebKit/chromium/src/WebHelperPluginImpl.cpp:231
> +	       m_page->mainFrame()->loader()->frameDetached();

Ah, if this works, this is much better.  This will trigger all the WebCore
internal state to be cleaned up as well.