[webkit-reviews] review denied: [Bug 87908] Add UNDO_MANAGER build flag : [Attachment 145879] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has denied Sukolsak Sakshuwong
<sukolsak at google.com>'s request for review:
Bug 87908: Add UNDO_MANAGER build flag
https://bugs.webkit.org/show_bug.cgi?id=87908

Attachment 145879: Patch
https://bugs.webkit.org/attachment.cgi?id=145879&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=145879&action=review


> Source/WebCore/editing/UndoManager.h:56
> +    RefPtr<Node> m_undoScopeHost;

It looks this RefPtr will make a circular reference between Document and
UndoManager.
Please take a look at ScriptedAnimationController or MediaQueryMatcher to see
how we can avoid this.