[webkit-reviews] review denied: [Bug 88497] Move form-related functions of Document to FormController : [Attachment 146195] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 7 17:24:18 PDT 2012

Hajime Morrita <morrita at google.com> has denied Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 88497: Move form-related functions of Document to FormController

Attachment 146195: Patch

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=146195&action=review

FormController could be under html/ considering that all its clients are under
Then it could be a member of HTMLDocument instead of Document.

> Source/WebCore/dom/Document.h:495
> +    Vector<String> formElementsState();

Why not const?

> Source/WebCore/dom/FormController.cpp:3
> + * Copyright (C) 2010, 2011 Google Inc. All rights reserved.

It's 2012

More information about the webkit-reviews mailing list