[webkit-reviews] review canceled: [Bug 76834] Relative pos. input fields in columns vanish when you start typing in them : [Attachment 145787] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has canceled Pravin D
<pravind.2k4 at gmail.com>'s request for review:
Bug 76834: Relative pos. input fields in columns vanish when you start typing
in them
https://bugs.webkit.org/show_bug.cgi?id=76834

Attachment 145787: Patch
https://bugs.webkit.org/attachment.cgi?id=145787&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145787&action=review


> Source/WebCore/rendering/RenderLayer.cpp:365
> +    if ((flags & UpdatePagination) || m_isPaginated)

I think it would be better to set the UpdatePagination flag in
FrameView::layout. The issue is that we are doing a subtree relayout and the
code makes the assumption that we would cross our parent with columns when
doing the recursive descent and properly set this flag.

There is 2 upsides to using the flag:
* takes care of new nodes as m_isPaginated will be false on them.
* the new check is unneeded in full layout mode as m_isPaginated will be false
or UpdatePagination will be properly set.