[webkit-reviews] review denied: [Bug 88576] [BlackBerry] Should Use the WebPage Already Created by Client, No Need to Create New One. : [Attachment 146392] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 7 14:50:47 PDT 2012


Rob Buis <rwlbuis at gmail.com> has denied Crystal Zhang <haizhang at rim.com>'s
request for review:
Bug 88576: [BlackBerry] Should Use the WebPage Already Created by Client, No
Need to Create New One.
https://bugs.webkit.org/show_bug.cgi?id=88576

Attachment 146392: patch
https://bugs.webkit.org/attachment.cgi?id=146392&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=146392&action=review


Found one tiny cleanup possibility. Crystal will have a look whether more
changes are needed.

> Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp:-312
> -	   webPopup->closeWebPage();

You can remove the { and } now.


More information about the webkit-reviews mailing list