[webkit-reviews] review denied: [Bug 88422] [Chromium] Remove header dependency of ImageDiff to WTF : [Attachment 146318] patch v2

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 88422: [Chromium] Remove header dependency of ImageDiff to WTF
https://bugs.webkit.org/show_bug.cgi?id=88422

Attachment 146318: patch v2
https://bugs.webkit.org/attachment.cgi?id=146318&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
(In reply to comment #13)
> Sorry for the mistake. I thought OS_xxxs were defined in gyp but actually
they are defined in chromium's build/build_config.h. Even they were useable,
there is no OS_WINDOWS but OS_WIN.

!? _WIN32 is normally defined by MSVC unless you specify otherwise.

> Changed to use _WIN32. Untested on chromium-win. Hope it work :)

Given that this change is mostly about Chromium Windows, I don't think it's
okay not to test it on Windows prior to landing. Please ask someone around you
to test this patch.

I'll r- this patch for now because this patch is landable until we confirm that
it builds on Chromium Windows.