[webkit-reviews] review granted: [Bug 88573] Fix recent null pointer error regression in the flakiness dashboard : [Attachment 146377] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 7 13:49:56 PDT 2012


Dirk Pranke <dpranke at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 88573: Fix recent null pointer error regression in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=88573

Attachment 146377: Patch
https://bugs.webkit.org/attachment.cgi?id=146377&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
looks fine to me, but my JS-fu isn't terribly strong. Is it possible for
something in the test to throw an exception that would cause doXHR not to be
reassigned back to oldDoXHR? i.e. does that need to wrapped in a try/finally
like you would in python?


More information about the webkit-reviews mailing list