[webkit-reviews] review denied: [Bug 88528] Reduce Node object size from 72 byte to 64 byte : [Attachment 146267] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 88528: Reduce Node object size from 72 byte to 64 byte
https://bugs.webkit.org/show_bug.cgi?id=88528

Attachment 146267: Patch
https://bugs.webkit.org/attachment.cgi?id=146267&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146267&action=review


I don't think this patch buy us any real memory saving.

> Source/WebCore/ChangeLog:14
> +	   e.g. The HTML spec
(http://www.whatwg.org/specs/web-apps/current-work/)
> +	   contains 325640 Nodes. Thus this patch saves 325640 * 8 byte = 2.6
MB.

I don't think this is true. Most of these nodes are Element and CharacterData
and they have virtual functions.
So you will have a vtable pointer in those objects anyway.