[webkit-reviews] review denied: [Bug 72103] box-shadow creates incorrect shadow when border-radius is too large : [Attachment 146249] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 72103: box-shadow creates incorrect shadow when border-radius is too large
https://bugs.webkit.org/show_bug.cgi?id=72103

Attachment 146249: Patch
https://bugs.webkit.org/attachment.cgi?id=146249&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=146249&action=review


> Source/WebCore/platform/graphics/Path.cpp:134
> +#if !PLATFORM(CHROMIUM) && !PLATFORM(MAC)
>      if (rect.width() < topLeftRadius.width() + topRightRadius.width()

Random platform #ifdefs are never a good thing in shared platform code. It's
impossible to know, by reading this, why Chromium or Mac behave differently.