[webkit-reviews] review requested: [Bug 88474] [GTK] run-api-tests should not buffer test stdout : [Attachment 146277] Another patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 88474: [GTK] run-api-tests should not buffer test stdout
https://bugs.webkit.org/show_bug.cgi?id=88474

Attachment 146277: Another patch
https://bugs.webkit.org/attachment.cgi?id=146277&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
I think we could use select to read the output to avoid the buffering. We would
still buffer lines, but we can send them to stdout when they are read, instead
of waiting for the whole command output. And to preserve the colored output of
google tests, we can use forkpty + exec instead of Popen.