[webkit-reviews] review granted: [Bug 73918] [Qt][WK2] Compute and set cache capacities using the current CacheModel : [Attachment 146254] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Michael Brüning
<michael.bruning at nokia.com>'s request for review:
Bug 73918: [Qt][WK2] Compute and set cache capacities using the current
CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918

Attachment 146254: Patch
https://bugs.webkit.org/attachment.cgi?id=146254&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146254&action=review


> Source/WebCore/platform/qt/FileSystemQt.cpp:222
> +#else
> +    struct statvfs volumeInfo;
> +    if (statvfs(path, &volumeInfo))
> +	   return 0;
> +
> +    return static_cast<uint64_t>(volumeInfo.f_bavail) *
static_cast<uint64_t>(volumeInfo.f_frsize);
> +#endif

IS this ensure to work on all non windows platforms (that we support)? :)

> Source/WebKit2/WebProcess/qt/WebProcessQt.cpp:104
> +    // The following variables are initialised to 0 because
WebProcess::calculateCacheSizes might not
> +    // set them in some rare cases.

Bug number for that?