[webkit-reviews] review denied: [Bug 88474] [GTK] run-api-tests should not buffer test stdout : [Attachment 146159] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 88474: [GTK] run-api-tests should not buffer test stdout
https://bugs.webkit.org/show_bug.cgi?id=88474

Attachment 146159: Patch
https://bugs.webkit.org/attachment.cgi?id=146159&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=146159&action=review


Yes, I never liked either, but it's used to get the pid and kill the test in
case of timeout.

> Tools/gtk/run-api-tests:215
>	       child_pid = self._get_child_pid_from_test_output(stdout)

stdout is used here, and you removed it. I'm fine with not buffering stdout but
we need to figure out a way to kill the tests when they timeout.