[webkit-reviews] review denied: [Bug 88212] [FileAPI] FileReader should throw an InvalidStateError exception when readyState is LOADING : [Attachment 146172] Patch

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has denied Li Yin <li.yin at intel.com>'s request
for review:
Bug 88212: [FileAPI] FileReader should throw an InvalidStateError exception
when readyState is LOADING
https://bugs.webkit.org/show_bug.cgi?id=88212

Attachment 146172: Patch
https://bugs.webkit.org/attachment.cgi?id=146172&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
Only a few minor comments.

View in context: https://bugs.webkit.org/attachment.cgi?id=146172&action=review


> Source/WebCore/ChangeLog:11
> +	   And delete OperationNotAllowedException related code, because it
won't be used.

nit: Also delete ... because it is not longer needed.

> Source/WebCore/ChangeLog:27
> +	   (WebCore::FileReader::readInternal):

Better to add some comment after each affected method is possible. For this
one, you can add the following:
  Changed to throw INVALID_STATE_ERR.

> Source/WebCore/ChangeLog:28
> +	   * fileapi/FileReader.idl:

Same for this one. You can add the following comment:
  Changed to raise DOMException for all read methods.