[webkit-reviews] review requested: [Bug 88363] [chromium] Separate CCVideoDrawQuad and from the layer tree and video provider by removing ManagedTexture and WebVideoFrame pointers from the quad : [Attachment 146140] Patch

[bugzilla-daemon at webkit.org]

Dana Jansens <danakj at chromium.org> has asked  for review:
Bug 88363: [chromium] Separate CCVideoDrawQuad and from the layer tree and
video provider by removing ManagedTexture and WebVideoFrame pointers from the
quad
https://bugs.webkit.org/show_bug.cgi?id=88363

Attachment 146140: Patch
https://bugs.webkit.org/attachment.cgi?id=146140&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
Please compare this with the previous patch. This version moves the texture
upload out of TextureCopier and makes use of LayerTextureSubImage instead, as
per some discussion with reveman.

The CCVideoLayerImpl then has to bind the textures itself, as we don't have any
infrastructure that would take a textureId and do the upload. We also discussed
the possibility of doing this texture upload outside of willDraw(), in some
other scheduler upload state (like an impl->impl commit sorta), so that the
time to draw a frame is predictable and does not include suddenly texture
uploads as it would for video. This is something we should persue afterwards.