[webkit-reviews] review denied: [Bug 85332] Add css3-images image-resolution (dppx only) : [Attachment 145930] Patch

Wed Jun 6 14:12:10 PDT 2012

Tony Chang <tony at chromium.org> has denied David Barr <davidbarr at chromium.org>'s
request for review:
Bug 85332: Add css3-images image-resolution (dppx only)
https://bugs.webkit.org/show_bug.cgi?id=85332

Attachment 145930: Patch
https://bugs.webkit.org/attachment.cgi?id=145930&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145930&action=review

r- because Ojan doesn't like the use of a ref-test.

On a side note, what are you plans for handling other images like images
referenced by CSS (e.g., background-image)?

> LayoutTests/ChangeLog:12
> +	   * fast/css/image-resolution/image-resolution-expected.html: Added.
> +	   * fast/css/image-resolution/image-resolution.html: Added.

I'm not a huge fan of using a ref test when a dumpAsText test would suffice
(it's slower to run and harder to make sense of the results).

> LayoutTests/fast/css/image-resolution/image-resolution.html:10
> +<body>
> +<script src="resources/image-resolution.js"></script>

Nit: Can you add a test description?  E.g., This test passes if no red is
showing.