[webkit-reviews] review denied: [Bug 15322] On designMode=on, <hr> elements should be ignored when moving the caret : [Attachment 145985] Praposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 6 12:15:01 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has denied Parag Radke <parag at motorola.com>'s
request for review:
Bug 15322: On designMode=on, <hr> elements should be ignored when moving the
caret
https://bugs.webkit.org/show_bug.cgi?id=15322

Attachment 145985: Praposed patch
https://bugs.webkit.org/attachment.cgi?id=145985&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
This isn't a right solution. previous/nextLeafWithSameEditability is used for
other purposes than just caret movement. Furthermore, as Justin said, we need
to add control selection on HR before skipping HR or else users won't be able
to delete HR.


More information about the webkit-reviews mailing list