[webkit-reviews] review denied: [Bug 84597] InsertUnorderedList and InsertOrderedList (execCommand) do not remove bullets : [Attachment 146011] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Arpita Bahuguna
<arpitabahuguna at gmail.com>'s request for review:
Bug 84597: InsertUnorderedList and InsertOrderedList (execCommand) do not
remove bullets
https://bugs.webkit.org/show_bug.cgi?id=84597

Attachment 146011: Patch
https://bugs.webkit.org/attachment.cgi?id=146011&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146011&action=review


Please fix nits below:

> Source/WebCore/ChangeLog:17
> +	   Comparison between start and end VisiblePositions will fail when a
position inside
> +	   a paragraph is compared with one at the start of the paragraph.
> +
> +	   This fix thus converts the end VisiblePosition (which could be
inside the paragraph)
> +	   to the start of the paragraph thereby enabling a proper comparison
of start and end
> +	   positions.

We normally put these long description after "Reviewed by" before the list of
tests wrapped in blank lines.

> LayoutTests/ChangeLog:12
> +	   This test verifies removing of an (un)ordered list on a selection
consisting of multiple
> +	   list items (paragraphs) when the end point of the selection points
to the end of the last
> +	   list item; followed by another paragraph not part of the
selection/list.

This should probably go after "Reviewed by" line but before the list of files.

> LayoutTests/editing/execCommand/remove-list-from-multi-list-items.html:3
> +<p>This test verifies removing of an (Un)OrderedList on a selection
consisting of multiple list items (paragaraphs) when the end point of the
selection points to the end of the last list item; followed by another
paragraph not part of the selection/list.</p>

You need to pass this to Markup.description.