[webkit-reviews] review denied: [Bug 88423] REGRESSION: Setting invalid media "src" does not cause "error" event : [Attachment 146048] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has denied Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 88423: REGRESSION: Setting invalid media "src" does not cause "error" event
https://bugs.webkit.org/show_bug.cgi?id=88423

Attachment 146048: Patch
https://bugs.webkit.org/attachment.cgi?id=146048&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=146048&action=review


> Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:85
> +SOFT_LINK_POINTER(QTKit, QTMovieOpenAsyncRequiredAttribute, NSString *)

This is will ASSERT if run on Leopard or older. Do we care?

> LayoutTests/http/tests/media/video-src-invalid-error.html:5
> +
> +

Nit: you have an extra blank line here.

> LayoutTests/http/tests/media/video-src-invalid-error.html:9
> +		   failTest("stalled but should not" );

Nit: you have an extra space before the closing brace.

> LayoutTests/http/tests/media/video-src-invalid-error.html:24
> +		   run("video.setAttribute('src', 'bogus.mp4')");

This will only work on ports that support MPEG-4. You should use
findMediaFile() and not log the file name.